Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-Jira - Bump RUM version #918

Merged
merged 3 commits into from
Apr 25, 2024
Merged

No-Jira - Bump RUM version #918

merged 3 commits into from
Apr 25, 2024

Conversation

wrandall22
Copy link
Contributor

@wrandall22 wrandall22 commented Apr 22, 2024

Description

Some more improvements to RUM here:

  • Upgraded from v4 to v5. See all changes from v4 to v5 here. Some main benefits include:
    • Collection of the new INP (Interaction to Next Paint) core web vital
    • A side effect of upgrading to v5 is that we no longer have to manually call startSessionReplayRecording()
    • Automatic collection of user frustration metrics
    • Automatic sending of OpenTelemetry when connecting to APM
  • To connect RUM and APM, I added the allowedTracingUrls configuration

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against f61cf8c

No significant changes found

…though there is a property called `startSessionReplayRecordingManually` that can be used to do this manually if we wanted to control when the recording starts.
@wrandall22 wrandall22 added the On Staging Will be merged to the staging branch by Github Actions label Apr 22, 2024
@wrandall22 wrandall22 marked this pull request as ready for review April 22, 2024 21:37
@wrandall22 wrandall22 requested a review from canac April 22, 2024 21:37
@canac
Copy link
Contributor

canac commented Apr 22, 2024

Looks good! Are you seeing GraphQL requests in the session replay? I didn't see any in my RUM session, so the allowedTracingUrls may not be configured correctly. Or I might just be looking in the wrong place.

@wrandall22
Copy link
Contributor Author

I did see it for some things

Screenshot 2024-04-24 at 10 05 50 AM

@canac
Copy link
Contributor

canac commented Apr 24, 2024

You're right. Maybe DataDog just didn't load in time to catch the network requests on the initial page load. There's a few places where we make requests to https://api.{stage.}mpdx.org/api/*, like exports for example. If we wanted to catch those, we could just use the origin of process.env.API_URL instead of the full URL. I think new URL(process.env.API_URL).origin should work.

@wrandall22 wrandall22 merged commit f8c580c into main Apr 25, 2024
18 checks passed
@wrandall22 wrandall22 deleted the rum-improvement branch April 25, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants