Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-Jira] Fix MUI menu component error #934

Merged
merged 1 commit into from
May 1, 2024
Merged

[no-Jira] Fix MUI menu component error #934

merged 1 commit into from
May 1, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Apr 30, 2024

Description

Fixes the MUI: The Menu component doesn't accept a Fragment as a child. error introduced in #925.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac
Fix MUI menu component error
cf922fc 
Error message: "MUI: The Menu component doesn't accept a Fragment as a
child."
@canac canac added the Preview Environment Add this label to create an Amplify Preview label Apr 30, 2024
@canac canac requested a review from dr-bizz April 30, 2024 20:49
@github-actions GitHub Actions
Copy link
Contributor

Preview branch generated at https://menu-component-error.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 427565b

No significant changes found

dr-bizz
dr-bizz approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this

@canac canac merged commit c189be2 into main May 1, 2024
19 checks passed
@canac canac deleted the menu-component-error branch May 1, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

Assignees
No one assigned
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canac @dr-bizz