Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-Jira Update contants names #971

Merged
merged 1 commit into from
Jul 10, 2024
Merged

No-Jira Update contants names #971

merged 1 commit into from
Jul 10, 2024

Conversation

caleballdrin
Copy link
Contributor

Description

https://cru-main.slack.com/archives/CG47BDCG6/p1718309741203709

  • Rename constants that were changed on the API.

oldType -> newType [EXAMPLE]
sendNewsletterOptions -> newsletter
pledgeCurrencies -> pledgeCurrency
pledgeFrequencies -> pledgeFrequency
statuses -> status
likelyToGiveOptions -> likelyToGive

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Jun 28, 2024
@caleballdrin caleballdrin requested a review from dr-bizz June 28, 2024 02:35
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against b3e0d9a

No significant changes found

@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Jun 28, 2024
Copy link
Contributor

Preview branch generated at https://rename-constants.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. I see the old refs are still in the .generated files, but they will get updated when this goes live.

I wouldn't go live with this untill more of us are around. Since Bill, myself and you are all out next week, lets wait to push this live until I get back on the July 8th

@caleballdrin
Copy link
Contributor Author

It looks good. I see the old refs are still in the .generated files, but they will get updated when this goes live.

I wouldn't go live with this untill more of us are around. Since Bill, myself and you are all out next week, lets wait to push this live until I get back on the July 8th

Sounds good. You can merge it in whenever you get back.

@dr-bizz dr-bizz merged commit 30b3ea5 into main Jul 10, 2024
19 checks passed
@dr-bizz dr-bizz deleted the rename-constants branch July 10, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants