MPDX-8022 - Fix Send Newsletter: Contact Status Display Value

[wrandall22]

Description

This PR updates the display of contact status to the friendly name instead of the enum id.

Checklist:

• I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
• I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
• I have requested a review from another person on the project

[github-actions]

Preview branch generated at https://MPDX-8022-fix-newsletter-status.d3dytjb8adxkk5.amplifyapp.com

[wrandall22]

I tried using Ergonomock for the test here, but I couldn't get it to use my value overrides on contact status, so I just mocked the hook instead.

[github-actions]

Bundle sizes [mpdx-react]

Compared against 6764d70

No significant changes found

[dr-bizz]

This looks great. The only update I see needing to be done is you could use the UseApiConstants hook to grab the constants here instead of adding constants to your query. src/components/Constants/UseApiConstants.tsx

[dr-bizz]

You could use the UseApiConstants hook to grab the constants here instead of adding constants to your query. src/components/Constants/UseApiConstants.tsx

[wrandall22]

I thought about doing that. The reason I didn't was performance. If I understand GraphQL correctly, this should grab only the statuses from the API (which probably takes it from the database) while not requesting the rest of the constants, thus saving 12 more database calls on the back-end. This way of doing it would also mean 1 HTTP request instead of 2. Perhaps it is not worth saving that processing?

[dr-bizz]

That is correct. It would be faster to just grab just the statuses, unless UseApiConstants has been called before causing it to be cached. Otherwise, you're correct.

It's hard to know if it's been called before, so I'm good with you leaving it the way it is if you want.

[dr-bizz]

When you start using the useApiConstants hook, that should help your CodeCov score. If it's not totally passing. I think you might be okay with merging it as you've tested the main function of the code.

[dr-bizz]

Approving to not be a blocker