Separate postgrescluster.Reconciler client concerns #4256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbandy
force-pushed
the
client-concerns
branch
from
bd59153 to
58a9e77
Compare
benjaminjb
reviewed
Sep 8, 2025
| obj.Labels = map[string]string{naming.LabelCluster: clusterName} | ||
|
|
||
| if err := r.Client.Create(ctx, obj); err != nil { | ||
| if err := tClient.Create(ctx, obj); err != nil { |
There was a problem hiding this comment.
It takes me a moment to remember what part is setup and what part is test, but when I do, I like this distinction
benjaminjb
approved these changes
Sep 8, 2025
cbandy
force-pushed
the
client-concerns
branch
from
779ce3f to
f862748
Compare
We want to be mindful of our interactions with the Kubernetes API, and these interfaces will help keep functions focused. These interfaces are also narrower than client.Reader and client.Writer and may help us keep RBAC markers accurate. A new constructor populates these fields with a single client.Client. The client.WithFieldOwner constructor allows us to drop our Owner field and patch method. This allows `make check` to cover 9% more of the "postgrescluster" package.
cbandy
force-pushed
the
client-concerns
branch
from
f862748 to
8e3e654
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same idea as #4253, but for the PostgresCluster controller: it separates the
client.Clientinterface into three. Similarly, this increases the amount of code covered bymake check.This refactor is another step toward my goal of a single, shared SSA Apply function.
Checklist:
Type of Changes:
Wait for these and rebase after: