Update testing tools #4328
Open
Update testing tools #4328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change caused this tool to select the *oldest* Kubernetes binaries rather than the newest: https://www.github.com/kubernetes-sigs/controller-runtime/issues/3379 This entire tool can be dropped when we move to controller-runtime 0.22.x which has this feature: https://www.github.com/kubernetes-sigs/controller-runtime/pull/3280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Recent PRs are failing due to updates to
golangci-lintandsetup-envtest:What is the new behavior (if this is a feature change)?
Tools are working and we can rely on PR checks again.