Remove pin on nbconvert to upgrade from 6.5.3 to 7.16.4 #117
Conversation
Bumps [nbconvert](https://github.com/jupyter/nbconvert) from 6.5.3 to 7.16.4. - [Release notes](https://github.com/jupyter/nbconvert/releases) - [Changelog](https://github.com/jupyter/nbconvert/blob/main/CHANGELOG.md) - [Commits](jupyter/nbconvert@6.5.3...v7.16.4)
|
|
|
/condalock |
environment.yml
Outdated
| @@ -45,7 +45,7 @@ dependencies: | |||
| # - jupyterlab-plotly~=5.18.0 # Outdated accoring to jupyterlab | |||
| - jupyterlab_pygments~=0.3.0 # To bring extension uptodate | |||
| - jupytext~=1.16.1 | |||
| - nbconvert==6.5.3 | |||
| - nbconvert~=7.16 | |||
There was a problem hiding this comment.
I've set the pin to ~=7.16 instead of ~7.16.4, so this should allow any versions of nbconvert >=7.16.0, <8.0
There was a problem hiding this comment.
The new constraint solves my specific problem. You may want to consider whether a constraint on nbconvert is just going to cause future trouble. The package is required by jupyterlab via jupyter-server, so why not just let the dependency resolver choose a version (by removing nbconvert as an explicit entry in environment.yml)? Either way, thanks for the fix!
There was a problem hiding this comment.
Actually, jupyter_server on conda-forge depends on nbconvert-core, not nbconvert (which consists of nbconver-core + nbconvert_pandoc).
I do see that voila (added last month in #114) depends on nbconvert >=6.4.5,<8, so we could definitely remove nbconvert and let the version be resolved by whatever voila needs. The original pin on nbconvert==6.5.3 was added in the first version of CryoCloud at 2554461/#2 back in Nov 2022, and it doesn't seem like there was a strong reason to pin to any specific version, it was probably just the latest version at that time.
There was a problem hiding this comment.
Ok, I've removed the explicit pin on nbconvert at commit 78fcba9. Just need someone to approve and I can merge this in.
There was a problem hiding this comment.
Had no idea conda-forge would change the dependencies from what the package developers specify. Risky, but in this case looks safe, I guess, if confusing. All sounds good to me.
There was a problem hiding this comment.
Yes, the naming is a little confusing, but see conda-forge/nbconvert-feedstock#72 for context. If I'm not mistaken, nbconvert-core on conda-forge is equivalent to nbconvert on PyPI without optional dependencies (see the recipe/meta.yaml file). I think they split out nbconvert-pandoc because pandoc is GPL licensed, so packaging both nbconvert (BSD-licensed) and pandoc might have GPL licensing implications.
|
/condalock |
weiji14
changed the title
Bumps nbconvert from 6.5.3 to 7.16.4.
Fixes #116.