feat: hide identity commitment #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmad
force-pushed
the
feature/hide-identity-commitment
branch
from
982b416
to
bd26968
Compare
0xisk
requested changes
Aug 22, 2023
0xmad
force-pushed
the
feature/hide-identity-commitment
branch
from
4e8f003
to
b57e61f
Compare
- [x] Hide identity commitment from external calls - [x] Minor style fixes - [x] Show identity metadata instead for connected identity
0xmad
force-pushed
the
feature/hide-identity-commitment
branch
from
b57e61f
to
63c57f6
Compare
0xisk
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR hides identity commitment and keeps it only inside the extension.
Details are below:
More Information
Related to #313
Screenshots/Screencaps
Manual Testing Steps
Pre-Merge Checklist