Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add group rpc methods for background #855

Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat: add group rpc methods for background #855

merged 2 commits into from
Sep 13, 2023

Conversation

0xmad
Copy link
Member

@0xmad 0xmad commented Sep 11, 2023

Explanation

This PR adds background services for group interaction.

Details are below:

  • Add join group method
  • Add generate membership proof method
  • Add empty request methods for provider

Related Issues

Related to #316

Screenshots

N/A

Manual Testing Steps

N/A

Pre-Merge Checklist

  • PR template is filled out
  • Pre-commit and pre-push hook checks are passed
  • E2E tests are passed locally
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

PR template source from github.com/MetaMask

@0xmad 0xmad added the 🌱 new feature Troubleshooting new feature issues label Sep 11, 2023
@0xmad 0xmad added this to the v0.3.0 milestone Sep 11, 2023
@0xmad 0xmad self-assigned this Sep 11, 2023
@0xmad 0xmad force-pushed the feature/join-group branch 2 times, most recently from 1b8cd59 to fdd48ec Compare September 12, 2023 14:12
@0xmad 0xmad mentioned this pull request Sep 12, 2023
12 tasks
- [x] Add join group method
- [x] Add generate membership proof method
- [x] Add empty request methods for provider
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xmad thanks all looks good to me, just left one simple comment.

Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xmad thanks!!

@0xmad 0xmad merged commit 9b72e84 into main Sep 13, 2023
10 checks passed
@0xmad 0xmad deleted the feature/join-group branch September 13, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 new feature Troubleshooting new feature issues
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants