Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically choose a Node for Installation #286

Closed
Tix-Hosting opened this issue Nov 12, 2021 · 12 comments · Fixed by #950
Closed

Automatically choose a Node for Installation #286

Tix-Hosting opened this issue Nov 12, 2021 · 12 comments · Fixed by #950
Assignees
Labels
Feature Adding a new feature, or substantial improvements on existing functionality Medium Priority Needs attention, not urgent

Comments

@Tix-Hosting
Copy link

🚀 Feature Request

Describe the solution you'd like

Provide a clear and concise description of what you want to happen.
For Example, "Automate the changing of x so I don't have to do it manually"

It is currently the case that in product linking it is possible to select the nodes on which the customer can install the server. Now, when creating the server, the customer can choose for himself which of the allowed nodes the server is to be installed.

I think it would be cool if there was an option that specifies that the panel automatically randomly selects a node on which the server is installed (taking into account whether there are still enough resources on the node for the server). The customer no longer has the confusion as to which node he should select and why, and it is also easier for administration, as the processes are automatically taken over by the system ... If there are no longer enough resources available on any of the permitted nodes, this can be output by an error message.

Additional context

Is there anything else you can add about the proposal?
You might want to link to related issues here, if you haven't already.

Product linking is kind of related to that :)

@Tix-Hosting Tix-Hosting added the Feature Adding a new feature, or substantial improvements on existing functionality label Nov 12, 2021
@AVMG20
Copy link
Collaborator

AVMG20 commented Nov 12, 2021

I like the idea, but how do you picture us to add this? cuss some ppl might like it that the customer can select the node, since one node may be stronger or better than another node, and this could be shown to the customer in price (and later also in showing specs or something of the node)

@anondev-sudo
Copy link
Contributor

anondev-sudo commented Nov 13, 2021

Maybe some random node should be selected, but there should be option to change it using drop down select

@Tix-Hosting
Copy link
Author

@AVMG20

I think what Anon Dev is a pretty good option! The panel automatically selects a node (as written in the Original Issue) and selects it automatically. Now the user can change this afterwards. Then in the options there is the option like: "LET_CUSTOMER_CHOOSE_NODE", this can be "True" or "False". If it is set to False, then the customer cannot change the automatic selection of the node because the option is grayed out and cannot be clicked ... :)

So both use cases are covered, those who want to let their users choose the node and also the others who do not want the customers to be able to choose a node :)

@Zoe8338
Copy link

Zoe8338 commented Jan 14, 2022

I like the idea, but how do you picture us to add this? cuss some ppl might like it that the customer can select the node, since one node may be stronger or better than another node, and this could be shown to the customer in price (and later also in showing specs or something of the node)

A switch which you can turn to choose node / location. If the switch is turned to "nodes" the costumer can choose which node to deploy in, if it's to location the costumer will only see the locations and the panel will decide the node to deploy in. This could be set by plan instead of system wide.

@anondev-sudo
Copy link
Contributor

pterodactyl/panel#3732
Don't forget that pterodactyl api will allow you to overallocate node, make sure to fetch node usage and check if it won't go over the set limits before creating server.

@wynn-dev
Copy link
Contributor

I think this should be prioritised. Having 20 or more nodes to choose from is a pain for both the client and the manager. Plus ppl creates servers on one node all the time, so I need to monitor usage on a daily basis.
I believe many people should feel my pain 🤣

@AGuyNamedJens
Copy link
Collaborator

I'm currently creating an addon that allows you to select the server's location (not node itself, the group of nodes pterodactyl calls a location) which will assign your server on the first possible node. Technically it could tackle this issue to resolved in the future

@anondev-sudo
Copy link
Contributor

You could PR it to this repo then to solve this issue

@1day2die
Copy link
Collaborator

yeah, but sadly many people think like this

image

@AGuyNamedJens
Copy link
Collaborator

The addon exists for the current version, will most likely be added into the core later, aiming at the new version for that

@1day2die 1day2die moved this to 📋 Backlog in CPGG Roadmap May 12, 2023
@GeckoBoy84 GeckoBoy84 moved this from 📋 Backlog to 🔖 Ready in CPGG Roadmap May 12, 2023
@GeckoBoy84 GeckoBoy84 moved this from 🔖 Ready to 📋 Backlog in CPGG Roadmap May 12, 2023
@GeckoBoy84 GeckoBoy84 moved this from 📋 Backlog to 🔖 Ready in CPGG Roadmap May 12, 2023
@AGuyNamedJens AGuyNamedJens moved this from 🔖 To Implement to 🏗 In progress in CPGG Roadmap May 7, 2024
@AGuyNamedJens AGuyNamedJens self-assigned this May 7, 2024
@AGuyNamedJens AGuyNamedJens linked a pull request May 7, 2024 that will close this issue
7 tasks
@AGuyNamedJens
Copy link
Collaborator

Will be in 0.9.9

@S0ly S0ly added Medium Priority Needs attention, not urgent and removed In Progress labels May 15, 2024
@S0ly
Copy link
Member

S0ly commented Jun 12, 2024

Closed by PR #950

@S0ly S0ly closed this as completed Jun 12, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in CPGG Roadmap Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Adding a new feature, or substantial improvements on existing functionality Medium Priority Needs attention, not urgent
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

9 participants