Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Location Addon Implementation #950

Merged
merged 11 commits into from
Jun 12, 2024

Conversation

AGuyNamedJens
Copy link
Collaborator

@AGuyNamedJens AGuyNamedJens commented May 7, 2024

After some consideration and acceptance of a Sponsor, I will be introducing my paid addon into the base of CtrlPanel accordingly with some fixes and tweaks.
Issue #948 will be closed once this is released.

Sidenote, will target the Development branch due to the new version we're planning to release.

Features that have been processed (will be updated accordingly, not going to spoil things beforehand)

  • Remaining localization from latest domain name change fixed
  • Initial deployment of the addon
  • Server description migration to support longer text
  • Optional setting to show location descriptions (descriptions from Pterodactyl)
  • Additional error message on full nodes
  • admin email notification wen region are full
  • fix a lot of bugs

Note: The changes labelled as "Bug Fix" MIGHT break existing installations, one main consideration will be the docker file overwriting "ControlPanel" with "CtrlPanel" as well as the folder structure "controlpanel" being replaced with "ctrlpanel".
Documentation will be updated later as well to provide the new changes.

@AGuyNamedJens AGuyNamedJens added Bug / Fix Something isn't working and may need a fix Feature Adding a new feature, or substantial improvements on existing functionality In Progress labels May 7, 2024
@AGuyNamedJens AGuyNamedJens self-assigned this May 7, 2024
@AGuyNamedJens AGuyNamedJens changed the title [Feature]: Location deployment and bugfixes [Feature]: Location deployment and bugfixes (v0.9.9) May 7, 2024
@AGuyNamedJens AGuyNamedJens added the Language Update This is to mark PRs regarding the Localization label May 7, 2024
@S0ly
Copy link
Member

S0ly commented May 10, 2024

That's nice seing all these issue resolved :D

@AGuyNamedJens AGuyNamedJens changed the title [Feature]: Location deployment and bugfixes (v0.9.9) [Feature]: Location Addon Implementation and Version 0.10 May 13, 2024
@AGuyNamedJens AGuyNamedJens added this to the V0.10 milestone May 13, 2024
@AGuyNamedJens
Copy link
Collaborator Author

AGuyNamedJens commented May 13, 2024

Just added the entire Development branch, this solves conflicts when this PR is pushed through.

@AGuyNamedJens AGuyNamedJens changed the base branch from main to development May 13, 2024 21:30
@S0ly S0ly removed the In Progress label May 15, 2024
@S0ly S0ly changed the title [Feature]: Location Addon Implementation and Version 0.10 Location Addon Implementation and Version 0.10 May 15, 2024
@S0ly S0ly added the High Priority Critical. Act quickly for resolution label May 15, 2024
@S0ly S0ly changed the title Location Addon Implementation and Version 0.10 Location Addon Implementation and Bug fix May 17, 2024
…ption)

[Feature]: Location description label on server create (optional setting)
@S0ly S0ly removed the v0.10 label May 25, 2024
@S0ly S0ly changed the title Location Addon Implementation and Bug fix feat: Location Addon Implementation Jun 4, 2024
@AGuyNamedJens AGuyNamedJens marked this pull request as ready for review June 9, 2024 15:26
@S0ly S0ly requested review from IceToast and S0ly June 9, 2024 15:31
Copy link
Member

@S0ly S0ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems okay, there is a lot of change not related to the PR title, and I we need ice to check in more detail, specially the mails please

@S0ly
Copy link
Member

S0ly commented Jun 9, 2024

@IceToast

Copy link
Collaborator

@IceToast IceToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, haven tested i

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug / Fix Something isn't working and may need a fix Feature Adding a new feature, or substantial improvements on existing functionality High Priority Critical. Act quickly for resolution Language Update This is to mark PRs regarding the Localization
Projects
Status: Done
3 participants