Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mercadopago Integration #926

Merged
merged 13 commits into from
Jul 24, 2024
Merged

feat: Mercadopago Integration #926

merged 13 commits into from
Jul 24, 2024

Conversation

drylian
Copy link
Contributor

@drylian drylian commented Jan 25, 2024

Just as they told me, I converted Mercadopago to work in the development version of cpgg, I tested the code version (requests) in the main version of cpgg, as I was unable to make the development version work, but I can guarantee that all the api will be working. If there is a problem with the API, I will resolve it and give another pull, unlike the old one that used the SDK, I preferred to use Mercadopago's own (tested) API, since the SDK generated some warnings when used.

@1day2die
Copy link
Collaborator

This is awesome. Thanks!

@drylian
Copy link
Contributor Author

drylian commented Mar 21, 2024

If you need anything or find an error, just let me know and I'll fix that part.😀

}
}

static function Checker(Request $request): void
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to follow the naming scheme already used in other payment gateways.

I standardized the functions to be the same as other payments, I removed MpPayment and only put it for the webhook to set the payment status (as done in Mollie) I changed the way Success works to the same as Mollie, I didn't understand what @ IceToast talked about Spatie, to me the way to call the Mercado Pago token appears to be correct
@S0ly S0ly added Feature Adding a new feature, or substantial improvements on existing functionality Low Priority Can wait, not urgent. Handle when possible labels May 15, 2024
@S0ly
Copy link
Member

S0ly commented May 16, 2024

I fixed the conflicts that was in the readme (dont forget to pull), the new readme does not show what system are used for payment because there are too mutch, whitout speaking of the addons that add even more :)

@MrWeez
Copy link
Collaborator

MrWeez commented May 22, 2024

@drylian Any news about the fixes?

drylian added 2 commits May 23, 2024 00:26
now I noticed that the use of MercadoPagoSettings was missing, The notificationId was changed to the correct values to be expected
Sorry, incorrect variable name laravelRequest,
@drylian
Copy link
Contributor Author

drylian commented May 23, 2024

@drylian Any news about the fixes?
I think it's correct now

@S0ly
Copy link
Member

S0ly commented May 23, 2024

@IceToast

I changed a little the way the Webhook responds to the MercadoPago, better filtering requests and expected values, I also added to getRedirectUrl a check necessary for the MercadoPago Webhook to work.
@S0ly S0ly changed the title mercadopago Integration feat: Mercadopago Integration Jun 4, 2024
@S0ly S0ly requested a review from IceToast June 13, 2024 22:28
@IceToast IceToast self-requested a review July 24, 2024 14:27
@IceToast
Copy link
Collaborator

@drylian Sorry, can you resolve that conflict to make the permission this PR adds readable.

For reference: #910

@drylian
Copy link
Contributor Author

drylian commented Jul 24, 2024

@drylian Sorry, can you resolve that conflict to make the permission this PR adds readable.

For reference: #910

this?

@MrWeez
Copy link
Collaborator

MrWeez commented Jul 24, 2024

@drylian Sorry, can you resolve that conflict to make the permission this PR adds readable.
For reference: #910

this?

You need to add Readable names for your permissions, as in #910

@drylian
Copy link
Contributor Author

drylian commented Jul 24, 2024

@MrWeez

image
I think that would be it, right? It's the only place that would need to change, the others still use arrays (views), and only this one had this change

@IceToast
Copy link
Collaborator

@MrWeez

image I think that would be it, right? It's the only place that would need to change, the others still use arrays (views), and only this one had this change

Looks goot to me

@IceToast IceToast merged commit 28cb09f into Ctrlpanel-gg:development Jul 24, 2024
@andremods1
Copy link

Como adicionar?

@MrWeez
Copy link
Collaborator

MrWeez commented Aug 31, 2024

Como adicionar?

This gateway is written for version 0.10, and it is incompatible with version 0.9.x

@andremods1
Copy link

Então não dá pra ter o Gateway do mercado pago

@MrWeez
Copy link
Collaborator

MrWeez commented Aug 31, 2024

Então não dá pra ter o Gateway do mercado pago

I don't quite understand you. Please use English, thanks.

@drylian
Copy link
Contributor Author

drylian commented Aug 31, 2024

Então não dá pra ter o Gateway do mercado pago

O mercado pago ta disponível apenas para a versão development, eu fiz originalmente duas versões, uma para a 0.10 e a pra 0.9, porém não aceitaram ela por que não estão aceitando pull nela, caso queria a do 0.9 fale comigo no Discord:drylian

@andremods1
Copy link

Já te segui lá

@S0ly
Copy link
Member

S0ly commented Aug 31, 2024

speak English or nobody will help.

@andremods1
Copy link

Ok

@drylian
Copy link
Contributor Author

drylian commented Aug 31, 2024

speak English or nobody will help.

He wanted the Mercado Pago gateway for 0.9, but this code is for 0.10+, I made it for 0.9 too, but it's not on cpgg's Github because they weren't accepting pull requests in the "main" repo.

@1day2die
Copy link
Collaborator

1day2die commented Nov 4, 2024

@drylian any updates?

@drylian
Copy link
Contributor Author

drylian commented Nov 4, 2024

@drylian any updates?

He wanted the Mercado Pago gateway for 0.9, but this code is for 0.10+, I made it for 0.9 too, but it's not on cpgg's Github because they weren't accepting pull requests in the "main" repo.

@1day2die
Copy link
Collaborator

1day2die commented Nov 4, 2024

i saw that.
if you can extract the code you can place it on the market. many people want it actually. if you want money for it or place it free is up to you. Otherwise i would jank your code and put it for free in the market until i implement it in v010

@drylian
Copy link
Contributor Author

drylian commented Nov 4, 2024

i saw that. if you can extract the code you can place it on the market. many people want it actually. if you want money for it or place it free is up to you. Otherwise i would jank your code and put it for free in the market until i implement it in v010

Honestly, if you want to do this, do it. I implemented the Mercado Pago code for people, and I really tried to put it in the official repository, but the people there didn't let me.
If you want to do it, at least tag me in the repository, so I can help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Adding a new feature, or substantial improvements on existing functionality Low Priority Can wait, not urgent. Handle when possible Payment Gateway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants