-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mercadopago Integration #926
feat: Mercadopago Integration #926
Conversation
This is awesome. Thanks! |
If you need anything or find an error, just let me know and I'll fix that part.😀 |
} | ||
} | ||
|
||
static function Checker(Request $request): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to follow the naming scheme already used in other payment gateways.
I standardized the functions to be the same as other payments, I removed MpPayment and only put it for the webhook to set the payment status (as done in Mollie) I changed the way Success works to the same as Mollie, I didn't understand what @ IceToast talked about Spatie, to me the way to call the Mercado Pago token appears to be correct
I fixed the conflicts that was in the readme (dont forget to pull), the new readme does not show what system are used for payment because there are too mutch, whitout speaking of the addons that add even more :) |
@drylian Any news about the fixes? |
now I noticed that the use of MercadoPagoSettings was missing, The notificationId was changed to the correct values to be expected
Sorry, incorrect variable name laravelRequest,
|
I changed a little the way the Webhook responds to the MercadoPago, better filtering requests and expected values, I also added to getRedirectUrl a check necessary for the MercadoPago Webhook to work.
…an/panel into mercadopago-implementation
Como adicionar? |
This gateway is written for version 0.10, and it is incompatible with version 0.9.x |
Então não dá pra ter o Gateway do mercado pago |
I don't quite understand you. Please use English, thanks. |
O mercado pago ta disponível apenas para a versão development, eu fiz originalmente duas versões, uma para a 0.10 e a pra 0.9, porém não aceitaram ela por que não estão aceitando pull nela, caso queria a do 0.9 fale comigo no Discord:drylian |
Já te segui lá |
speak English or nobody will help. |
Ok |
He wanted the Mercado Pago gateway for 0.9, but this code is for 0.10+, I made it for 0.9 too, but it's not on cpgg's Github because they weren't accepting pull requests in the "main" repo. |
@drylian any updates? |
He wanted the Mercado Pago gateway for 0.9, but this code is for 0.10+, I made it for 0.9 too, but it's not on cpgg's Github because they weren't accepting pull requests in the "main" repo. |
i saw that. |
Honestly, if you want to do this, do it. I implemented the Mercado Pago code for people, and I really tried to put it in the official repository, but the people there didn't let me. |
Just as they told me, I converted Mercadopago to work in the development version of cpgg, I tested the code version (requests) in the main version of cpgg, as I was unable to make the development version work, but I can guarantee that all the api will be working. If there is a problem with the API, I will resolve it and give another pull, unlike the old one that used the SDK, I preferred to use Mercadopago's own (tested) API, since the SDK generated some warnings when used.