Forced Discord Account and Mail Verification #93
Conversation
#72 This is configurable using: VERIFIED_DISCORD_TO_MAKE_SERVER and VERIFIED_EMAIL_TO_MAKE_SERVER')
| @@ -38,6 +33,16 @@ public function create() | |||
| return redirect()->route('servers.index')->with('error', "You've already reached your server limit!"); | |||
| } | |||
|
|
|||
| //Required Verification for creating an server | |||
| if(Configuration::getValueByKey('VERIFIED_EMAIL_TO_MAKE_SERVER') === 'true' && !Auth::user()->hasVerifiedEmail()) { | |||
There was a problem hiding this comment.
You can add a default value to 'getValueByKey' by using the second param ('KEY' , 'DEFAULT_VALUE') that way if the key is somehow missing this would still work and not trow errors or unexpected behaviour :)
There was a problem hiding this comment.
Done in new PR (#95) (sadly I was not able to commit into this one)
| } | ||
|
|
||
| //Required Verification for creating an server | ||
| if(Configuration::getValueByKey('VERIFIED_DISCORD_TO_MAKE_SERVER') === 'true' && !Auth::user()->discordUser) { |
There was a problem hiding this comment.
check comment above :)
To what method have you added this script? should be added to both the create and store method to prevent any bypasses
There was a problem hiding this comment.
Done in new PR (#95) (sadly I was not able to commit into this one)
| Configuration::firstOrCreate([ | ||
| 'key' => 'VERIFIED_DISCORD_TO_MAKE_SERVER', | ||
| ], [ | ||
| 'value' => 'true', |
There was a problem hiding this comment.
not much besides turning on the extra spacing options for array's :P
could you also rename the keys to something like (FORCE_EMAIL_VERIFICATION)
and perhaps add a small description explaining what this option does :)
I've already done this to all of the config options, but it seems like you are running an older version.
There was a problem hiding this comment.
Done in new PR (#95) (sadly I was not able to commit into this one)
|
Already solved |
#72 This is configurable using:
VERIFIED_DISCORD_TO_MAKE_SERVER and VERIFIED_EMAIL_TO_MAKE_SERVER