Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LegacySettingsMigrations #941

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

IceToast
Copy link
Collaborator

This PR fixes the settingsmigration for all old settings as described here:
https://discord.com/channels/787829714483019826/851144461361872957/1203989679557312552

image

@IceToast IceToast added High Priority Critical. Act quickly for resolution fix labels Apr 12, 2024
@IceToast IceToast added this to the V0.10 milestone Apr 12, 2024
@IceToast IceToast requested review from 1day2die and Ferks-FK April 12, 2024 12:06
@IceToast IceToast self-assigned this Apr 12, 2024
@IceToast IceToast marked this pull request as ready for review April 12, 2024 19:03
Copy link
Collaborator

@Ferks-FK Ferks-FK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes.

@1day2die
Copy link
Collaborator

lgtm

@IceToast IceToast requested review from Ferks-FK and 1day2die and removed request for Ferks-FK April 25, 2024 08:04
@Ferks-FK Ferks-FK merged commit fa857e8 into development Apr 25, 2024
@MrWeez MrWeez deleted the feature/fix-legacy-settings-migrations branch May 31, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Critical. Act quickly for resolution
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants