-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompting before deleting a time #231
Comments
jmlumpkin
added a commit
to jmlumpkin/CubeTime
that referenced
this issue
Oct 10, 2024
…TimeDetailView.
jmlumpkin
added a commit
to jmlumpkin/CubeTime
that referenced
this issue
Oct 12, 2024
Ive added this to the three places I noticed you were able to delete a time. I plan on next adding an option so that under settings one can determine if they want this on or not (and probably defaulting to off, since its what is there now) |
jmlumpkin
added a commit
to jmlumpkin/CubeTime
that referenced
this issue
Oct 21, 2024
Found that there was a race condition on the timelistview. Added a preference (default false, to stay as it currently exists) that now prompts on the 3 places to delete a solve.
Just created pull request #235. Thanks for letting me try this out! |
pdtxie
added a commit
that referenced
this issue
Oct 27, 2024
#231 - Adding a prompt before deleting times (and a preference to control)
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe if applicable.
While you may want to often delete times rather quickly, it can also be frustrating as it can adjust your averages or recordings, if you inadvertently delete a time. It would be nice to have a prompt here first before the delete. This could be a configurable option too, as in let the user say that they want to be prompted or not.
Describe the solution you'd like
I would like to see a common alert pop up confirming that yes, I do want to delete a time.
Additional context
I am actually working on some code to implement this. So far I have added it to the TimeDetail.
The text was updated successfully, but these errors were encountered: