-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux]Show progress in window icon #284
base: trunk
Are you sure you want to change the base?
Conversation
* added progress indication via app icon (#284) * changed build setup and code for qt6 compatibility * tweaked app icon * tweaked screenshots for better readablilty * tweaked default layout
Interesting, I didn't really know anything about DBus. However, this implementation is specifc to only few desktop environments. (Seems to be mostly for Ubuntu/Unity, but might be KDE compatible. It doesn't seem to work on the KDE 4 system that I've available though.) We can get a similar result though, by drawing on the app icon. It's not as integrated as the native approach, I'm still tweaking the look. Windows has very small icons compared to some of the other DEs. |
Except Linux. The Linux World is currently transiting from XServer to Wayland. Wayland don't allow Applications to set a own Icon. It will just use the Icon from the desktop file. Even on other Platforms this could be a Problem. Nobody is expecting a Window Icon to do such things. This could cause some weird Problems. It's better to just use the native Implementation of each Platform.
I know, but if a Desktop don't want to show a Progress Bar, than this should not be forced. KDE is known to work. It is also supported by the Dash to Dock GNOME Extension. It is probably also supported by other Programs/Desktops.
We could just enable it for the Flatpak/the AUR package. I'm also not sure if compiling without D_Bus could cause some Issues.
Wow, that's really old. |
It would work on almost all systems that have an XServer, which I would guess is still the majority of Linux systems.
A lot of image viewers and some editors show a live miniature of their content for their window icon. I will concede though that it is uncommon for other applications to do this. My plan had been to make this a feature which can be enabled in the settings.
When you want to keep ABI compatibility, you tend to use the oldest maintained LTS OS releases available, usually Debian or Centos, so the binaries will work on all the newer OSes. This has the side effect that a lot of the software can be 5 or even 10 years behind. I have taken the liberty to adapt your PR to the current trunk, and I've disabled the setWindowIcon() code. |
I got it working now on Gnome. The API needs the correct desktop file. GNOME was for some reason not aviable to connect the Window to the desktop file, even when launching from the Menu. Please don't ask me why. You can tell this by hovering with the Mouse over the Icon. If it shows On never KDE versions it should work as expected, as long as you have the desktop file installed. You may need to start Cubiomes Viewer from the Menu.
A little tip: You can check if a Window is Wayland or XWayland by using xeyes. Just start xeyes and move the cursor in the Window around. If xeyes follows the cursor, the Window is XWayland, if not it's Wayland.
Wayland is for some reason a Qt Plug-in at the Moment. Maybe you don't have it installed for some reason. A lot of image viewers and some editors show a live miniature of their content for their window icon. GIMP is the only one I know and they have dropped it.
A lot of Distros that use GNOME/KDE ship with Wayland as default. GNOME is already planning on removing X11. KDE 6 will use Wayland as default. Lots of smaller Desktops are working on a Wayland session. Fedora 40 is planning the ship without XServer. I think we will see X11 vanish from the default configuration most distros in the next 1 or 2 Years. |
This shows the current progress in the window icon on Linux. It is not supported by every desktop. You can use KDE if you want to test it. Cubiomes Viewer must be installed to make this work.
This is also possible under Windows, but I don't know how it works there.