Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #70

Merged
merged 4 commits into from
Mar 6, 2022
Merged

Dev #70

merged 4 commits into from
Mar 6, 2022

Conversation

Cuiyansong
Copy link
Owner

No description provided.

@Cuiyansong Cuiyansong merged commit 72ae8a0 into Cuiyansong:master Mar 6, 2022
<!--

<head>
<meta charset="utf-8" />
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

格式化不符合换行规则。。。

});
},
[dispatch],
);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use callback hook?

: null;
export function getThemeFromStorage(): ThemeKeyType {
const theme = window.localStorage
? (localStorage.getItem('selectedTheme') as ThemeKeyType)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

selectedTheme better to SELECTED_THEME in enum?

@@ -94,7 +97,8 @@
"@dinero.js/currencies": "^2.0.0-alpha.8",
"@reduxjs/toolkit": "^1.7.1",
"@types/react-color": "^3.0.5",
"antd": "4.16.13",
"antd": "^4.16.13",
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

antd 还是锁版本比较好

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants