We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The url that is returned when a file has been uploaded (using Amazon S3 in my testing) is missing a '/'.
e.g. 'https:/bucket.s3-us-west-2.amazonaws.com' instead of 'https://bucket.s3-us-west-2.amazonaws.com'.
This issues does not occur in version 0.4.0, but it is present in 0.6.0.
Thanks!
The text was updated successfully, but these errors were encountered:
The offending line is this. path.join joins and then normalizes, resulting in '//' -> '/'
path.join
'//'
'/'
Sorry, something went wrong.
@gsuess Would the following code work as a replacement:
downloadPath = (directive.cdn || bucketUrl) + '/' + payload.key;
Or is the path.join needed for sanitization?
Another shamelessly simple solution seems:
downloadPath = path.join((directive.cdn || bucketUrl), payload.key), downloadPath = downloadPath.replace('/', '//');
CulturalMe#84 of parent
8ba4c94
Fixes #84
a3956ad
Do not use NPM path for processing http URLs.
Fixes #84 - Bump version
754c84d
gsuess
Successfully merging a pull request may close this issue.
The url that is returned when a file has been uploaded (using Amazon S3 in my testing) is missing a '/'.
e.g. 'https:/bucket.s3-us-west-2.amazonaws.com' instead of 'https://bucket.s3-us-west-2.amazonaws.com'.
This issues does not occur in version 0.4.0, but it is present in 0.6.0.
Thanks!
The text was updated successfully, but these errors were encountered: