fix(Web SDK): [no-issue] Further improvements and fixes #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhommes
reviewed
Oct 18, 2024
| const range = | ||
| min !== undefined && max !== undefined ? max - min : undefined; | ||
|
|
||
| if (range !== undefined && range < 1) { |
There was a problem hiding this comment.
Should we add more smaller ranges? Can we somehow make an algorithm out of this?
function getDecimalPlaces(num: number): number { const numStr = num.toString(); const decimalIndex = numStr.indexOf('.'); if (decimalIndex === -1) { return 0; // No decimal point found } return numStr.length - decimalIndex - 1; }
janhommes
reviewed
Oct 18, 2024
| /> | ||
| <span></span> | ||
| <span translate>Date selection in the widget view.</span> | ||
| <button |
There was a problem hiding this comment.
The padding of this element is somehow off. Can we make it more dense?
janhommes
reviewed
Oct 18, 2024
| widgetInstanceGlobalTimeContext: false, | ||
| }); | ||
| } else if (dateSelection === DATE_SELECTION.DASHBOARD_CONTEXT) { | ||
| } else { |
janhommes
reviewed
Oct 18, 2024
| this.dateSelection = DATE_SELECTION.CONFIG; | ||
| } else { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixeds/Improvements:
Types of changes
Paste Link to the issue
Checklist
Further comments