#1 Load all tenant options #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnaether-c8y
requested changes
Dec 15, 2023
| } catch (error) { | ||
| console.error(error); | ||
|
|
||
| return undefined; |
There was a problem hiding this comment.
Returning undefined while not handling that case in the reload method of the tenant-option.component.ts will lead to an NPE when trying to call find on undefined. I would rather not want to catch it and let it bubble up the promise chain.
There was a problem hiding this comment.
changed it to return an empty array and create an alert if an error occurred while loading the tenant options
hnaether-c8y
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and support pagination when loading all tenant options