Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve consistency for marker / anchor tag's visual representation #47

Closed
videosmith opened this issue Jan 30, 2022 · 2 comments
Closed

Improve consistency for marker / anchor tag's visual representation #47

videosmith opened this issue Jan 30, 2022 · 2 comments
Assignees
@Cuperino
Labels
bug Something isn't working enhancement New feature or request
Milestone
1.x

Comments

@videosmith
Copy link

Your default script has several marked elements with no visible tags, however when I add a marker to highlighted text, over and under-scores decorate the text.

Detailed description of display configuration (if applicable)

...

Screenshots (if applicable)

...
Screenshot from 2022-01-30 11-00-38
Screenshot from 2022-01-30 11-01-37

Device information

  • Operating System: [Raspberry Pi 4b Debian Bullseye 64bit latest updates]
  • QPrompt Version: [e.g. 1.0.0]

...
@Cuperino Cuperino added bug Something isn't working enhancement New feature or request labels Feb 1, 2022
@Cuperino Cuperino added this to the 1.x milestone Feb 1, 2022
@Cuperino Cuperino changed the title Marker tag visibility Improve consistency for marker / anchor tag's visual representation Feb 1, 2022
@Cuperino
Copy link
Owner

Cuperino commented Feb 1, 2022

Since documents in the editor are HTML, marker were made using HTML anchor tags to improve compatibility with scripts coming from Imaginary Teleprompter. Nevertheless, markers created inside of QPrompt are not represented in the same way as traditional anchors. This makes it seem like the markers from the default script aren't showing, when in fact they just look like ordinary hyperlinks, and this here was the mistake.

Both regular anchors and markers created from within QPrompt should use the same visual representation for consistency purposes.

@Cuperino
Copy link
Owner

Cuperino commented Feb 1, 2022

Issue fixed for next release.

Anchors in HTML from other sources now look like anchors created in QPrompt.

@Cuperino Cuperino closed this as completed Feb 1, 2022
Cuperino pushed a commit that referenced this issue Feb 1, 2022
Fixed issue #50: cannot set same color attribute with text color and …
cff8509 
…text highlight twice in a row.

Fixed issue #47: HTML anchors created externally and HTML anchors created in QPrompt didn't share the same formatting.
Enhanced: Hid unnecessary alpha channel slider on mobile QML color ColorDialog.
@Cuperino Cuperino moved this to Done in QPrompt Feb 25, 2023
@Cuperino Cuperino added this to QPrompt Feb 25, 2023
@Cuperino Cuperino modified the milestones: 2.x, 1.x Nov 17, 2024
Cuperino pushed a commit that referenced this issue Dec 1, 2024
Fixed issue #50: cannot set same color attribute with text color and …
93c2c2c 
…text highlight twice in a row.

Fixed issue #47: HTML anchors created externally and HTML anchors created in QPrompt didn't share the same formatting.
Enhanced: Hid unnecessary alpha channel slider on mobile QML color ColorDialog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Cuperino Cuperino

Labels
bug Something isn't working enhancement New feature or request
Projects
QPrompt
Status: Done
Milestone
1.x
Development

No branches or pull requests
2 participants
@Cuperino @videosmith