Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove /benches #354

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove /benches #354

wants to merge 2 commits into from

Conversation

hinto-janai
Copy link
Contributor

What

Removes /benches (replaced by https://github.com/Cuprate/benches), updates documentation.

Why

hinto: boog900: What do you think about moving /benches to another repo? It being in the monorepo causes some pain for others since builds/clippy/CI/etc will break if something /benches uses is changed, which must now be fixed by that person. I assume reviewing changes to /benches is a pain too. Realistically I'll be the main person maintaining it so I think it may be better if there were a Cuprate/benches or something.

boog900: Yeah that does sound like a good idea, although needing to keep up with the mono repo could get annoying in the future. For now it is probably better to have a separate repo as the review process does not need to be as strict.

@github-actions github-actions bot added A-dependency Related to dependencies, or changes to a Cargo.{toml,lock} file. A-workspace Changes to a root workspace file or general repo file. A-docs Related to documentation. A-benches Related to benchmarks. A-books Related to Cuprate's books. A-book-architecture Related to the Architecture book. labels Dec 3, 2024
This was referenced Dec 3, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Open
hinto-janai added a commit to hinto-janai/cuprate that referenced this pull request Dec 3, 2024
@hinto-janai
remove /benches Cuprate#354
d52597c
@hinto-janai hinto-janai added the P-low Low priority. label Dec 3, 2024
@hinto-janai hinto-janai marked this pull request as ready for review December 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-benches Related to benchmarks. A-book-architecture Related to the Architecture book. A-books Related to Cuprate's books. A-dependency Related to dependencies, or changes to a Cargo.{toml,lock} file. A-docs Related to documentation. A-workspace Changes to a root workspace file or general repo file. P-low Low priority.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hinto-janai