rpc/types: add missing defaults to fields #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinto-janai
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Maybe worth noting that this is indirectly fixed by #355 (comment), although that may be temporary and this change is needed regardless.
Co-authored-by: hinto-janai <hinto.janai@protonmail.com>
|
Yeah I don't like the idea of making every field have a default, I am ok with it as a temporary solution though. Monero actually gives every field a default as well (I don't think intentionally), which has lead to problems: monero-project/monero#9570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fields were missing defaults: https://github.com/monero-project/monero/blob/893916ad091a92e765ce3241b94e706ad012b62a/src/rpc/core_rpc_server_commands_defs.h#L265-L266
reported by @spirobel