Introduce simulation functionality #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f63a2a9.
…Analytics.jl into jiachengzhang1-master
…arAnalytics.jl into development
…arAnalytics.jl into development
|
Two thoughts:
|
|
Yes, we need to remove the data file from the Simulation code — it’s specific to UA.
I will start working on some tests.
… On Aug 27, 2020, at 12:06 PM, Hayden Free ***@***.***> wrote:
Two thoughts:
We may not want to distribute such a large data file (48mb) with the source code.
We'll need tests written for the simulation code. As is this will bring our code coverage down 8.3% to 45%
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#100 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5I52U6XWFIHGAIB2AFGDSC2VCVANCNFSM4QNJ7ILA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to simulate student progress through a curriculum