Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PlayerChatListener.java #98

Open
wants to merge 1 commit into
base: dev-v4
Choose a base branch
from

Conversation

Kalibrier
Copy link

Should fix the "Could not pass event AsyncPlayerChatEvent" error

Should fix the "Could not pass event AsyncPlayerChatEvent" error
@Almighty-Satan
Copy link
Collaborator

This does not work as is.

without this patch:
image
with this patch:
image

Setting the format to %2$s should fix this.

@Almighty-Satan Almighty-Satan changed the base branch from master to dev-v4 November 13, 2024 18:39
@Almighty-Satan
Copy link
Collaborator

On second thought I'm not sure if we should modify the message at all as this might interfere with other plugins that rely on the AsyncPlayerChatEvent. It would be better to properly escape all special characters and just set the format string

@Kalibrier
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants