-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade OOVPA symbol group files #208
Draft
RadWolfie
wants to merge
29
commits into
master
Choose a base branch
from
upgrade-symbol-groups
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+3,635
−1,830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
OOVPA
Any OOVPA change relative
needs-verification
Require verification before approval
D3D8
OOVPA relative topic
D3D8LTCG
OOVPA relative topic
DSOUND
OOVPA relative topic
XACTENG
OOVPA relative topic
JVS
OOVPA relative topic
XGRAPHIC
OOVPA relative topic
XNET
OOVPA relative topic
XONLINE
OOVPA relative topic
XAPI
OOVPA relative topic
TOOLS
labels
Jul 15, 2024
RadWolfie
force-pushed
the
upgrade-symbol-groups
branch
3 times, most recently
from
July 15, 2024 09:56
4917ddb
to
13a672e
Compare
ergo720
reviewed
Jul 19, 2024
ergo720
reviewed
Jul 19, 2024
ergo720
reviewed
Jul 19, 2024
ergo720
reviewed
Jul 19, 2024
ergo720
reviewed
Jul 19, 2024
RadWolfie
force-pushed
the
upgrade-symbol-groups
branch
from
July 21, 2024 07:28
13a672e
to
4a7fb4a
Compare
ergo720
reviewed
Jul 21, 2024
RadWolfie
force-pushed
the
upgrade-symbol-groups
branch
from
July 25, 2024 13:46
2568904
to
b7b2901
Compare
RadWolfie
force-pushed
the
upgrade-symbol-groups
branch
from
August 13, 2024 01:14
81602d6
to
cc21074
Compare
RadWolfie
force-pushed
the
upgrade-symbol-groups
branch
from
September 12, 2024 08:45
cc21074
to
5d98655
Compare
RadWolfie
force-pushed
the
upgrade-symbol-groups
branch
from
September 13, 2024 11:43
0794a67
to
d8310b2
Compare
plus fill in the parameters per requirement
RadWolfie
force-pushed
the
upgrade-symbol-groups
branch
from
September 18, 2024 03:46
d8310b2
to
ea91bc1
Compare
…native xref string table
RadWolfie
force-pushed
the
upgrade-symbol-groups
branch
from
September 20, 2024 13:56
ea91bc1
to
6009daa
Compare
RadWolfie
force-pushed
the
upgrade-symbol-groups
branch
from
September 20, 2024 14:01
6009daa
to
b999211
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CMAKE
D3D8LTCG
OOVPA relative topic
D3D8
OOVPA relative topic
DSOUND
OOVPA relative topic
JVS
OOVPA relative topic
needs-verification
Require verification before approval
OOVPA
Any OOVPA change relative
TOOLS
XACTENG
OOVPA relative topic
XAPI
OOVPA relative topic
XGRAPHIC
OOVPA relative topic
XNET
OOVPA relative topic
XONLINE
OOVPA relative topic
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
upgrade-symbol-groups
branch, in this pull request, is currently in major work in progress and not a final design.Note
GitHub CI build may can fail at any time, do not worry about it.
Note
Some things may not be fully done due to in need for other internal changes to enable such various support.
Such as self-register symbols support.
resolve #122
Some changes to symbol names are require to functional with new upgrade system.
Currently undetermined for OFFSET swapped in prefix and suffix field.(now always use suffix)Also, some symbols may have additional/removed parameters. These symbols will need their own OOVPA revision to separate and provide correct parameters and stack size usage.
New feature for CLI tool:
DSOUND__FUN__CDirectSoundStream_GetInfo(stk pThis, stk pInfo) = 0x########
.UnitTest may have not been updated with symbol name changes.
Checklist of symbol group files has been done:
Review remarks are welcome. 🙂
Pull request to
upgrade-symbol-groups
branch for incomplete symbol group file are also welcome too.Best thing to do is look for TODO notes relative to parameters change or the like and any
/*unknown*/
comments.TODO: