Skip to content

Conversation

SvenKube
Copy link

@SvenKube SvenKube commented Oct 1, 2025

This PR add support for the slin16 audiosocket message kind added to asterisk in asterisk/asterisk#1492

@SvenKube
Copy link
Author

SvenKube commented Oct 1, 2025

I would keep this as a draft until the PR in the Asterisk repo has been merged.

@Ulexus
Copy link
Member

Ulexus commented Oct 1, 2025

FWIW, Asterisk's current implementation does not adhere to the 0x10 = slin (16-bit, 8kHz) spec. It sends that for all codecs... which is rather irritating, but they chose to re-interpret 0x10 to be general "audio" as opposed to audio of a particular codec.

I'm not at all averse to adding more types here for more codecs, but unless/until Asterisk actually adheres to such a spec, I'm afraid it will not be of much use. I guess we can see how your PR to Asterisk plays out.

Copy link
Member

@Ulexus Ulexus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; should wait until the upstream actually merges, but I appreciate the effort on both sides.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants