'disabled' applied only when true, 'required' applied only when true and not disabled #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n true and not disabled
|
@ymarcon thanks so much. First look looks all good. Will merge and release later this week. |
|
Could you make a pre-release instead of (or in addition of) the @next snapshot ? What's your plan with releasing 1.0.0? |
|
@ymarcon closed in favour of cherry pick: I plan to release 1.0.0 ideally in 2021 : D
I'm working on BlitzTable during December. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure for the required flag, as I was not able to test.
I had to upgrade esbuild because of evanw/esbuild#1711 (comment)