*very* basic cleanup #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice, thanks a lot! There's a lot of branches out there, and it's not clear which one is best... When I needed a solution for Bookyt I found a branch that was a major refactor, but worked much better for my case than the original one. I still think we should unite, and some time ago I tried, but as you mention... it's a mess;-) I'll take a look at the open branches and will merge some. So I'd rather wait with this cleanup to reduce noise. I think it's valuable to fix the rubocop issues though, just after some merges. |
|
Just files an issue over at betterplace#11 |
|
@luxflux: do you have needs in the area of MT940 bank data imports? Now would be the time;-) |
|
@huerlisi Thanks for the notice. But right now we don't have any needs... 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @huerlisi,
this PR are some applied rubocop rules and is a basic dependency update.
I'm not happy how the code was and I'm still not happy how the code is after the PR but if no one ever begins it will always stays as it is.
Do you have any plans to merge some of the latest changes of betterplace?
I tried to merge on some point but it results in a total mess as I haven't enough background information about some specifics and the use in bookyt.
There are obviously also totally different ideas about the field number
86.But having parse some issues solved would be wonderful.
Thank you very much