Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to output only legacy builds #3

Merged
merged 1 commit into from
Sep 10, 2023
Merged

feat: add option to output only legacy builds #3

merged 1 commit into from
Sep 10, 2023

Conversation

k-yle
Copy link
Contributor

@k-yle k-yle commented Sep 8, 2023

Hi! this PR cherrypicks vitejs/vite#10139, which introduced a new option called renderModernChunks.

This option was released in @vitejs/plugin-legacy v4.1 so it would be nice to have the same option in vite-plugin-legacy-swc

The patch file for this PR and the original PR should be virtually identical

@CyanSalt
Copy link
Owner

CyanSalt commented Sep 8, 2023

Great porting job!

However, since this project is still crude at this moment, I need to spend some time verifying and releasing the changes here. I think I may need to finish these a few days later.

Anyway, thx for contribution!

@CyanSalt CyanSalt merged commit 3cf8370 into CyanSalt:master Sep 10, 2023
@CyanSalt
Copy link
Owner

LGTM and has been released in v0.4.0.

@k-yle k-yle deleted the renderModernChunks-only branch September 10, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants