Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [sc-34004] Changelog modal appears on first submission of a learning object #1879

Merged
merged 1 commit into from
Oct 23, 2024
Merged

fix: [sc-34004] Changelog modal appears on first submission of a learning object #1879

merged 1 commit into from
Oct 23, 2024

Conversation

Greek
Copy link
Member

@Greek Greek commented Oct 21, 2024 •
edited
Loading

Our first submission check was expecting isFirstSubmission, not firstSubmission. This is fixed now.

Story details: https://app.shortcut.com/clarkcan/story/34004/changelog-modal-appears-on-first-submission-of-a-learning-object

@Greek
isFirstSubmission -> firstSubmission
f4f6c09 
Signed-off-by: Andreas <andreas.papacharalampous@secured.team>
@Greek Greek requested a review from a team October 21, 2024 18:03
@Greek Greek self-assigned this Oct 21, 2024
pzalep1
pzalep1 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@pzalep1 pzalep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Greek Greek merged commit 5a71520 into clark-service-refactor Oct 23, 2024
1 check passed
@Greek Greek deleted the bug/sc-34004/changelog-modal-appears-on-first-submission branch October 23, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stef359 stef359 stef359 approved these changes

@dsoto18 dsoto18 dsoto18 approved these changes

@Cwagne17 Cwagne17 Cwagne17 approved these changes

@pzalep1 pzalep1 pzalep1 approved these changes

@Romerico234 Romerico234 Awaiting requested review from Romerico234 Romerico234 was automatically assigned from Cyber4All/developers

@rstraug1 rstraug1 Awaiting requested review from rstraug1 rstraug1 was automatically assigned from Cyber4All/developers

@joaquinVill joaquinVill Awaiting requested review from joaquinVill joaquinVill was automatically assigned from Cyber4All/developers

Assignees

@Greek Greek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Greek @pzalep1 @Cwagne17 @dsoto18 @stef359