fix: [sc-33835] Throw warning for malformed ACL in secured-auth-service instead of error #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cwagne17
requested review from
Greek,
pzalep1,
dsoto18,
stef359,
Romerico234,
rstraug1 and
joaquinVill
pzalep1
approved these changes
Oct 9, 2024
Greek
approved these changes
Oct 9, 2024
joaquinVill
approved these changes
Oct 10, 2024
stef359
approved these changes
Oct 11, 2024
dsoto18
approved these changes
Oct 11, 2024
Cwagne17
deleted the
bug/sc-33835/throw-warning-for-malformed-acl-in-secured
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/clarkcan/story/33835
Tried adopting an AWS SDK approach to error handling by having multiple classes for handling so we can do switch statements and equality checks for errors in the secured-auth-service. This way we can differentiate. Also we added a default don't throw error on validateAclArray with the options (which can be updated) this way we just get the array of ACLs back and the PDP can make the decision.