Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put labels around checkboxes in subscriptions #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WebFreak001
Copy link
Contributor

So you can click the text and not aim for the checkbox

@CyberShadow
Copy link
Owner

TIL you can put <label> around the <input> without a for attribute.

Did you test whether this affects how the form looks?

@WebFreak001
Copy link
Contributor Author

uh I didnt test it because DFeed wants to download like 15 years of forum messages and that took way too long. But it shouldn't affect anything because label is like a span element.

@wilzbach
Copy link
Contributor

uh I didnt test it because DFeed wants to download like 15 years of forum
messages and that took way too long. But it shouldn't affect anything
because label is like a span element

AFAIK you can abort it and on the next run (with a semi-filled database) it
won't query for the forum messages again.

On Sat, Oct 15, 2016, 22:49 Jan Jurzitza notifications@github.com wrote:

uh I didnt test it because DFeed wants to download like 15 years of forum
messages and that took way too long. But it shouldn't affect anything
because label is like a span element.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#77 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEKwdvwG3Kp87KUacfd1jpJBtpJeABXyks5q0TxYgaJpZM4KXxiq
.

@CyberShadow
Copy link
Owner

But it shouldn't affect anything because label is like a span element.

There might be some interaction with some CSS rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants