Remove two uses of fully qualified names that rely on a DMD bug#50
Merged
CyberShadow merged 1 commit intoCyberShadow:masterfrom Apr 2, 2021
Merged
Conversation
BorisCarvajal
commented
Feb 24, 2021
|
|
||
| import ae.net.ietf.wrap; | ||
|
|
||
| alias ae.utils.text.ascii.ascii ascii; // https://d.puremagic.com/issues/show_bug.cgi?id=12156 |
Contributor
Author
There was a problem hiding this comment.
This line should be an error but I didn't fix it because the alias seems no longer needed, ascii is already available given the import ae.utils.text; a little above.
I'm not sure if that is going to break building with a very old compiler.
Owner
|
Something doesn't seem right, replied in the DMD PR: dlang/dmd#12215 (comment) |
Contributor
Author
|
The pull was merged and deprecation should be there. |
Owner
|
Yep, looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fully-qualified names are not really exposed in the current scope but are accessible due to bug dlang/dmd#12215.