Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: case-sensitive header lookup in HttpResponse getValue method #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jm-riley
Copy link

Description

Currently, the getValue method in HttpResponse performs a case-sensitive lookup of header keys after lowercasing the input key. This causes issues when response headers like "Digest" need to be retrieved as part of verification.

While creating the transient token, response from /flex/v2/tokens request contains a response header of Digest. Calling DigestHelper.verifyResponseDigest() will always throw a missingDigestHeader error when attempting to assign digestHeader value:

guard let digestHeader = response.getValue(for: "Digest") else {
    throw FlexInternalErrors.missingDigestHeader.errorResponse
}

This change modifies the HttpResponse.getValue() function to:

  1. First attempt an exact key match
  2. Only apply case-insensitive comparison if exact match fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant