Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added environment tag #152

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Added environment tag #152

merged 3 commits into from
Jul 14, 2022

Conversation

reesercollins
Copy link
Member

SUMMARY

See apache#20295 for details

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: https://cccs.atlassian.net/browse/CLDN-1460
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

superset/config.py Show resolved Hide resolved
Copy link
Member

@cccs-Dustin cccs-Dustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than making the changes to the hogwarts_superset_deployment repo and the .devcontainer repo, lgtm!

@reesercollins reesercollins merged commit 2786907 into cccs-1.5 Jul 14, 2022
@reesercollins reesercollins deleted the feature/CLDN-1460 branch July 14, 2022 14:03
cccs-RyanS pushed a commit that referenced this pull request Jul 25, 2022
* Added environment tag and relevant tests

* Reorganize imports
cccs-rc pushed a commit that referenced this pull request Mar 6, 2024
* Added environment tag and relevant tests

* Reorganize imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants