Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added option to emit a filter from a default column for a row in ag grid #220

Merged

Conversation

cccs-RyanK
Copy link
Member

@cccs-RyanK cccs-RyanK commented Oct 14, 2022

SUMMARY

Ability to specify a default column to emit in ag grid viz, so that when right clicking on any cell the filter emits from the same standard column(s)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

chart creator
image
chart context menu
image

TESTING INSTRUCTIONS

  • Create a chart
  • enable emit filters
  • add default column(s)
  • In the dashboard view, when right clicking on that chart the option of emit default filters will appear in the drop down.
  • clicking emit default filters will emit the filter for the selected row, but with the specified default column

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

cccs-RyanK and others added 3 commits October 19, 2022 09:29
…src/CccsGrid.tsx

Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com>
…nu' of github.com:CybercentreCanada/superset into emit-a-filter-for-a-default-column-in-aggrid-context-menu
@cccs-RyanK cccs-RyanK merged commit 6d8dc99 into cccs-2.0 Nov 15, 2022
@cccs-RyanK cccs-RyanK deleted the emit-a-filter-for-a-default-column-in-aggrid-context-menu branch November 15, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants