CLDN-2447 Add suppressFieldDotNotation flag to ag grid #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cccs-rc
approved these changes
Jan 30, 2024
cccs-joel
approved these changes
Jan 31, 2024
cccs-RyanK
added a commit
that referenced
this pull request
Feb 22, 2024
cccs-RyanK
added a commit
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Columns with '.' in them do not show up properly in AG-Grid due to it trying to use Field Dot Notation: https://www.ag-grid.com/javascript-data-grid/column-definitions/#accessing-row-data-values. I do not think it is even possible to use this feature in superset so I think it is best to disable it.
This PR adds the suppressFieldDotNotation flag to the ag grid component to avoid this behavior and properly render column names with '.' in them.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION