Refactor: reduce complexity by removing unused functionality #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixauringer
force-pushed
the
refactor/linting-and-testing
branch
from
3f03848 to
53e56a1
Compare
felixauringer
force-pushed
the
refactor/linting-and-testing
branch
from
53e56a1 to
7a7d2f9
Compare
|
I think this closes the following issues @j2ein. Please correct me if I am wrong.
|
felixauringer
force-pushed
the
fix/8-first-loop
branch
from
4f0e71e to
6b42264
Compare
This removes the following things: - anything with tests because there are not tests - unused and undocumented Makefile targets Furthermore, the Makefile `docker` target is now able to use CGO because this is also not disabled in the pipelines and some dependencies cannot build without it.
felixauringer
force-pushed
the
refactor/linting-and-testing
branch
from
7a7d2f9 to
d4bbfe9
Compare
felixauringer
force-pushed
the
refactor/linting-and-testing
branch
from
d4bbfe9 to
7467ebb
Compare
j2ein
approved these changes
Nov 4, 2024
This issue was from @SilvanVerhoeven , and I think "the missing commands" meant the additional parameter that was needed to specify for development purpose (specifying custom backend, etc.) So this is no problem for us, as a normal usage of bees does not require those flags.
The issue is addressed.
I agree with you that the bee should return more meaningful error, so I agree with your decision to have that issue open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.