Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: make Vulnerability objects comparable by fields #463

Closed
SaberStrat opened this issue Jul 19, 2024 · 0 comments
Closed

Enhancement: make Vulnerability objects comparable by fields #463

SaberStrat opened this issue Jul 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@SaberStrat
Copy link

One way to fix DependencyTrack/dependency-track#3834 and make vulnerabilities elements in BOMs and VEXs unique, is to make Vulnerability objects comparable to one another on a fields basis. To get this, we need custom equals and hashCode methods.

This would be part of the fix to the above issue I'm working on in the PR DependencyTrack/dependency-track#3948.
This was referenced Jul 20, 2024
Merged
Merged
SaberStrat pushed a commit to SaberStrat/dependency-track that referenced this issue Jul 25, 2024
Use full Vulnerability object to check for dupes
49a9380 
Use all fields of Vulnerability objects, except for `affects`, for
deduplicated.
Requires CycloneDX/cyclonedx-core-java#463.

Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
@nscuro nscuro added the enhancement New feature or request label Aug 1, 2024
@nscuro nscuro closed this as completed in b7b99fa Aug 6, 2024
SaberStrat pushed a commit to SaberStrat/dependency-track that referenced this issue Aug 7, 2024
Use full Vulnerability object to check for dupes
84fa366 
Use all fields of Vulnerability objects, except for `affects`, for
deduplicated.
Requires CycloneDX/cyclonedx-core-java#463.

Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
SaberStrat pushed a commit to SaberStrat/dependency-track that referenced this issue Aug 7, 2024
Bump org.cyclonedx.cyclonedx-core-java
3881bd7 
Bump library to use the version containing the required enchangement
CycloneDX/cyclonedx-core-java#463

Signed-off-by: Kirill.Sybin <kirill.sybin@lex-com.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nscuro @SaberStrat