Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CycloneDX 1.6.1 #552

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Support CycloneDX 1.6.1 #552

merged 3 commits into from
Nov 22, 2024

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Nov 18, 2024

fixes #551

  • fetched latest schema from https://github.com/CycloneDX/specification/blob/1.6.1/schema/bom-1.6*
  • fetched latest tests from https://github.com/CycloneDX/specification/tree/master/tools/src/test/resources/1.6

@jkowalleck jkowalleck requested a review from a team as a code owner November 18, 2024 09:45
@jkowalleck
Copy link
Member Author

some tests seam to fail.

I am not familiar with this setup and the Java implementation.
Could you help me out, @stevespringett, @nscuro,

@mr-zepol
Copy link
Contributor

#551

I can help checking this

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f9b5bea) 6072 4456 73.39%
Head commit (fce34d4) 6072 (+0) 4460 (+4) 73.45% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#552) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@mr-zepol
Copy link
Contributor

@jkowalleck Test issues fixed

@mr-zepol
Copy link
Contributor

SInce I made some changes it does not make sense I approve, but they look good to me

@nscuro nscuro added this to the 10.0.0 milestone Nov 22, 2024
@nscuro nscuro merged commit d9f8d4c into master Nov 22, 2024
11 checks passed
@nscuro nscuro deleted the feat/cdx1.6.1 branch November 22, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CycloneDX 1.6.1
3 participants