Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CycloneDX 1.6.1 #370

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

andreas-hilti
Copy link
Contributor

@andreas-hilti andreas-hilti commented Nov 24, 2024

Closes: #368

  • Update schema and tests to version 1.6.1
  • Fix downgrading of external references
  • Add CryptoRefArray in ProtocolProperties
  • Change Data in Component to a List
  • Fix xml serialization of component (order of elements)

Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
Signed-off-by: andreas hilti <69210561+andreas-hilti@users.noreply.github.com>
@andreas-hilti andreas-hilti marked this pull request as ready for review November 24, 2024 12:25
@jkowalleck jkowalleck requested a review from a team January 2, 2025 09:30
@andreas-hilti
Copy link
Contributor Author

Should this one also support the change of sensitiveData from string to array?

https://github.com/CycloneDX/specification/blob/d570ffb8956d796585b9574e57598c42ee9de770/schema/bom-1.6.schema.json#L3372 (array)

https://github.com/andreas-hilti/cyclonedx-dotnet-library/blob/bbf8d477b7d99d17e2f8227cd64c5dda1a6e5caf/src/CycloneDX.Core/Models/Data.cs#L86 (string)

You are correct that it is wrong, but this is not related to the 1.6.1 schema, thus, I would prefer to handle it in a separate issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support CycloneDX 1.6.1
2 participants