Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuget package from private feed not found on nuget.org results in error ("Central Directory corrupt.") #748

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dreammaster38
Copy link

Hi,

I just stumbled about an error while trying to create SBOM from nuget packages not found on public nuget.org.
The error message was "Central Directory corrupt." because the package couldn't be downloaded from nuget.org by default.
Now i just check if the package really exists on nuget.org before trying to read any info.

Feel free to integrate this bugfix into your release if you like.

Kind regards
Thomas

@NextFreeUsername
Copy link

We run into this issue with the 2.8.1 version as well, but only with prerelease nugets. With release nugets this works fine, with prerelease nugets we get the same error.
So I don't think the issue is with private feed or not, our release nugets are also on private feeds.

@mtsfoni
Copy link
Contributor

mtsfoni commented Sep 27, 2023

Hello dreammaster38,

unfortunately, you didn't sign-off your commits, thus I cannot merge them. Please consider signing them off.

See here for some more information: https://github.com/CycloneDX/cyclonedx-dotnet/pull/748/checks?check_run_id=15953566656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants