Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for spec v1.5 #90

Merged
merged 15 commits into from
Dec 9, 2023
Merged

feat: add support for spec v1.5 #90

merged 15 commits into from
Dec 9, 2023

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented May 21, 2023

This PR implements support for version 1.5 of the CycloneDX specification.

Coverage

See https://github.com/CycloneDX/specification/milestone/6

Note
More changes are to come as the spec approaches the v1.5 release.

Closes #109
Closes #115

@wagoodman
Copy link

It looks like all tasks on this PR are completed (merged), does that mean that full support for 1.5 is complete? or is there more work needed?

@nscuro
Copy link
Member Author

nscuro commented Oct 19, 2023

Hey @wagoodman apologies for the delayed response. You are correct that most features are implemented, however the majority is not merged to main yet. The PRs I linked in the description above are from the upstream specification repository (to help me keep track of which features need implementation).

There are some more or less minor tasks outstanding (see #115). Depending on which features of v1.5 you need, perhaps v0.7.2 is sufficient for you already. If you need something that has not been released yet, let me know and I'll see if I can expedite.

@chris-rock
Copy link

If I see this right, EvidenceOccurrences is missing from 1.5 spec in the implementation.

@bluesentinelsec
Copy link

@nscuro Hello, I just wanted to raise a demand signal regarding support for the updated Tools object.

Do you have an ETA for this at this time?

I know you're habitually busy and don't mean to pile on.

The deprecated Tools array is causing one of our services to throw spec-compliance errors, i.e., (array found, object expected), so I am just weighing options right now.

nscuro added 12 commits December 7, 2023 19:32
Signed-off-by: nscuro <nscuro@protonmail.com>
…n analysis

Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
…n identity

Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
…vidence

Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro
Copy link
Member Author

nscuro commented Dec 7, 2023

Hey @bluesentinelsec thanks for reaching out. Actually I'll have a go at this on the weekend. I am annoyed myself that I haven't yet managed to get this done. I will not promise anything but I'll make an effort to ship at least what has been done so far in this PR, as well as a solution to the tools situation.

closes #115

Signed-off-by: nscuro <nscuro@protonmail.com>
this project should be simple to work with, and we don't want contributors (including ourselves) having to install exotic tools.

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro
Copy link
Member Author

nscuro commented Dec 9, 2023

@chris-rock EvidenceOccurrence is already there:

cyclonedx-go/cyclonedx.go

Lines 358 to 361 in 64eb0c8

type EvidenceOccurrence struct {
BOMRef string `json:"bom-ref,omitempty" xml:"bom-ref,attr,omitempty"`
Location string `json:"location,omitempty" xml:"location,omitempty"`
}

@nscuro
Copy link
Member Author

nscuro commented Dec 9, 2023

Decoupled the last remaining task into #130 to get this PR merged.

@nscuro nscuro marked this pull request as ready for review December 9, 2023 18:03
@nscuro nscuro requested a review from a team as a code owner December 9, 2023 18:03
@nscuro nscuro merged commit b9654ae into master Dec 9, 2023
8 checks passed
@nscuro nscuro deleted the spec-v1.5 branch December 9, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spec/1.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backward/forward compatibility for Tools (cdx 1.5) Specification version 1.5 support
4 participants