Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: validators return errors, not throw them #691

Merged
merged 4 commits into from
Apr 24, 2023

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Apr 24, 2023

the previous behavior of validators needed some improvements,
as test-integrations with the release candidate showed. ...

here they are now.

@jkowalleck jkowalleck added the enhancement New feature or request label Apr 24, 2023
@jkowalleck jkowalleck requested a review from a team as a code owner April 24, 2023 11:29
@codacy-production
Copy link

codacy-production bot commented Apr 24, 2023

Coverage summary from Codacy

Merging #691 (7edc032) into main (080b63b) - See PR on Codacy

Coverage variation Diff coverage
0.00% (target: -1.00%) 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (080b63b) 5902 5803 98.32%
Head commit (7edc032) 5898 (-4) 5799 (-4) 98.32% (0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#691) 43 43 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the validator-return-errors branch from 4bc6cf9 to 9cb5ec2 Compare April 24, 2023 12:04
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck merged commit a69ad25 into main Apr 24, 2023
@jkowalleck jkowalleck deleted the validator-return-errors branch April 24, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant