Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make log output more easy to understand by sorting #542

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Bananeweizen
Copy link
Contributor

Sort the log output for excluded artifacts as well as not depended upon artifacts. That makes comparing multiple builds much easier than reading the "randomly sorted" looking output (it's not really random, but driven by the dependency order).

There is no functional change in which order the plugin iterates dependencies and calculates entries in the SBOM. Only the log output is sorted:

grafik

fixes #541

Side note: It's impossible to run integration tests behind a company proxy because of takari/takari-plugin-testing-project#16

Sort the log output for excluded artifacts as well as not depended upon
artifacts. That makes comparing multiple builds much easier than reading
the "randomly sorted" looking output (it's not really random, but driven
by the dependency order).

Signed-off-by: Michael Keppler <michael.keppler@gmx.de>
@jkowalleck jkowalleck requested a review from hboutemy November 11, 2024 07:23
@hboutemy hboutemy changed the title Make log output more easy to understand by sorting dependencies Make log output more easy to understand by sorting Nov 12, 2024
Copy link
Contributor

@hboutemy hboutemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable: I changed the title because I did not get it was sorting only output messages, not really dependencies (in the SBOMs) = something I would not agree

@hboutemy hboutemy merged commit db2a35b into CycloneDX:master Nov 12, 2024
3 checks passed
@hboutemy
Copy link
Contributor

thank you

@Bananeweizen Bananeweizen deleted the sort_output branch December 23, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort log output for easier understanding of excluded/not depended upon artifacts
2 participants