root component gets a fallback name

fix #252

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

.github/workflows/nodejs.yml

@@ -56,6 +56,9 @@ jobs:
       - name: install testing-project "with-dev-dependencies"
         run: npm ci
         working-directory: tests/with-dev-dependencies
+      - name: install testing-project "with-dev-dependencies"
+        run: npm ci
+        working-directory: tests/no-name
       - name: run tests
         run: >
           npm run test:unit --

model/Bom.js

@@ -35,7 +35,11 @@ class Bom extends CycloneDXObject {
     if (includeSerialNumber) {
       this._serialNumber = 'urn:uuid:' + uuid.v4()
     }
-    if (pkg) {
+    if (pkg && typeof pkg === 'object') {
+      if (!pkg.name) {
+        pkg = Object.assign({}, pkg) // work with a modified/fixed clone
+        pkg.name = 'NO-NAME-PACKAGE'
+      }
       this._metadata = this.createMetadata(pkg, componentType)
       this._components = this.listComponents(pkg, lockfile)
     } else {

test.sh

@@ -8,6 +8,7 @@ npm ci
 ## install testing-projects
 npm ci --prefix 'tests/with-packages'
 npm ci --prefix 'tests/with-dev-dependencies'
+npm ci --prefix 'tests/no-name'
 
 ## run tests
 npm test

tests/index.test.js

@@ -111,3 +111,15 @@ test('createbom produces a BOM when all dependencies are dev-dependencies that s
     done()
   })
 })
+
+test('createbom produces a BOM when there is no name in the root package', done => {
+  // test for https://github.com/CycloneDX/cyclonedx-node-module/issues/252
+  bomHelpers.createbom('library', false, true, './tests/no-name', { dev: true }, (err, bom) => {
+    expect(err).toBeFalsy()
+
+    bom.metadata.timestamp = timestamp
+    bom.metadata.tools[0].version = programVersion
+    expect(bom.toJSON()).toMatchSnapshot()
+    done()
+  })
+})

tests/no-name/README.txt

@@ -0,0 +1,2 @@
+this test case is related to
+https://github.com/CycloneDX/cyclonedx-node-module/issues/252

tests/no-name/package.json

@@ -0,0 +1,7 @@
+{
+  "description": "an package without a name. see https://github.com/CycloneDX/cyclonedx-node-module/issues/252",
+  "private": true,
+  "dependencies": {
+    "packageurl-js": "^0.0.1"
+  }
+}