refactor: move versionCompare to internal helpers (#1256)

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>

src/_helpers.ts

@@ -104,3 +104,28 @@ export function getMimeForLicenseFile (filename: string): MimeType | undefined {
 }
 
 // endregion MIME
+
+// region version compare
+
+type Version = number[]
+type CompareResult = -1 | 0 | 1
+
+export function versionCompare (a: Version, b: Version): CompareResult {
+  let ai: number, bi: number
+  for (let i = 0, l = Math.max(a.length, b.length); i < l; ++i) {
+    // make values NaN-save, null-safe, undefined-safe
+    ai = a[i] || 0 /* eslint-disable-line @typescript-eslint/strict-boolean-expressions */
+    bi = b[i] || 0 /* eslint-disable-line @typescript-eslint/strict-boolean-expressions */
+    if (ai < bi) {
+      // A < B
+      return -1
+    }
+    if (ai > bi) {
+      // A > B
+      return +1
+    }
+  }
+  // A == B
+  return 0
+}
+// endregion version compare

src/builders.ts

@@ -28,11 +28,11 @@ import {
   isString,
   loadJsonFile,
   structuredClonePolyfill,
-  tryRemoveSecretsFromUrl
+  tryRemoveSecretsFromUrl,
+  versionCompare
 } from './_helpers'
 import { makeNpmRunner, type runFunc } from './npmRunner'
 import { PropertyNames, PropertyValueBool } from './properties'
-import { versionCompare } from './versionCompare'
 
 type OmittableDependencyTypes = 'dev' | 'optional' | 'peer'
 

tests/unit/versionCompare.spec.js

@@ -19,7 +19,7 @@ Copyright (c) OWASP Foundation. All Rights Reserved.
 
 const { describe, expect, test } = require('@jest/globals')
 
-const { versionCompare } = require('../../dist/versionCompare')
+const { versionCompare } = require('../../dist/_helpers')
 
 describe('versionCompare', () => {
   test.each([