[FEATURE] Deserialize(denormalize) JSON/XML documents to Python objects(data model)

[garethr]

I'd like to be able to take existing CycloneDX documents, and work with them as Python objects. This library has the models, but I didn't see a from_xml or from_json method or similar.

This would make building tooling that consumes SBOMs much easier.

[jkowalleck]

Thanks for the feature request, @garethr .

most important question for now: do you plan on implementing the feature yourself, or do you request it to be implemented?

---

initial thoughts, that we could dicsuss, @madpah :

Feasibility

This library is feature complete regarding data models, having everything in place from 1.0 to 1.4 spec.
Feasibility: check ✔️

Input validation

When it comes to deserializing/denormalizing it is preferred to validate the input document(JSON/XML) first. Therefore a schema detection and a JSON/XML schema validator is required.
These features are currently in a non-public state for the library. We might need to improve them, before making them public.
(possible discussion: do we depend on additional 3rd party libs, or are they optional dependencies and we switch of deserializing if the deps are missing?)

possible implementation details

to be discussed: architecture, design
keywords: (some answers may be obvious)

• where would a python module be placed/named in the project - folder/file path?
• do we call them deserializer or denormalizer?
• to what level are tests required, what test coverage is acceptable?
• do we intend to work with abstract base-classes(protcols) that will be implemented in a XML and a JSON denormalizer - or go with bare implements?
• what public (helper) functions/methods/interfaces should exist?
• how will schema detection and schema validation happen? are they optional? are they additional functionality or a internal part of the deserialization process?
• what will happen if a deserialization input is insufficient/invalid according to spec?

[madpah]

@garethr - great idea, we should look into providing this.

@jkowalleck - we're not 100% complete on schema coverage yet - see the following known open feature requests:

• [FEAT] Add support for arbitrary properties at the BOM level (bom.properties) #125
• [FEAT] add support for JSF Signatures #122
• [FEATURE]: Add support for dependencies (bom.dependencies) #7

[iandh]

I'm part of a team that also needs this feature.

We started working on a parser, and would be happy to contribute something back that was better aligned to this team's vision.

The biggest hurdle we experienced is inconsistent naming between model __init__ method arguments and model fields (and some not matching the json schema).

I'm a big fan of pydantic for handling serialization but I realize thats a bit of an architectural change.

[madpah]

Thanks for joining the conversation @iandh. Let us take a look at your work and pydantic and we'll come back to you shortly.

Thanks again!

[derwahla]

I would also be very happy if that feature would be available. Is there any progress on this issue?

[jkowalleck]

Hello @alexwahl ,

There is no implementation done so far. Are you interested in contributing any?
If so, feel free to get in contact with @madpah, he considered this feature for version 3 that is currently in preparation.

[nettrino]

I would be interested in contributing / helping build towards such functionality - I think it should be doable to auto-generate the python classes based on the spec right? (e.g., https://github.com/CycloneDX/specification/blob/1.4/schema/bom-1.4.schema.json) @madpah happy to sync offline if you have started working on this already

[jkowalleck]

re: #185 (comment)

I think it should be doable to auto-generate the python classes based on the spec right

totally. if the input file was validated positive against the schema to use, then a generic/auto-generated code should work 👍

[idunbarh]

We did a similar exercise too and released it as hoppr_cyclonedx_models package to support Hoppr.

• https://gitlab.com/lmco/hoppr/hoppr-cyclonedx-models/-/tree/main/hoppr_cyclonedx_models

There was some minor changes from what pydantic created but otherwise was straight forward. It loads json great.

[derwahla]

I would also be happy to contribute. I already created a loader cyclonedx_fileparser which is used in a private project. But this code is not complete, please see it as work in progress.