Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: poetry analyzer crashed with certain optional package's version constraints #703

Merged
merged 6 commits into from
Mar 28, 2024

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Mar 28, 2024

fixes #702

Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck added the bug Something isn't working label Mar 28, 2024
@jkowalleck jkowalleck requested a review from a team as a code owner March 28, 2024 20:21
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.06% (target: -1.00%) 92.31% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (59f07c1) 1023 988 96.58%
Head commit (0cb8750) 1034 (+11) 998 (+10) 96.52% (-0.06%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#703) 13 12 92.31%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@jkowalleck jkowalleck merged commit 8ade6e1 into main Mar 28, 2024
33 checks passed
@jkowalleck jkowalleck deleted the fix/issue702 branch March 28, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error while reading version specifier in poetry.lock
1 participant